open-feature / ruby-sdk

Ruby implementation of the OpenFeature SDK
https://openfeature.dev
Apache License 2.0
23 stars 8 forks source link

fix: OpenFeature::SDK::Configuration uses concurrent-ruby gem even though it doesn't depend on it #61

Closed technicalpickles closed 1 year ago

technicalpickles commented 1 year ago

This PR

I am surprised our specs are passing as is, because we don't have a dependency on concurrent-ruby currently.

I seemed to remember talking with @josecolella about this, and we decided to go with regular type Array for now. I was pretty sure we implemented that, but I guess not 🙃

Related Issues

Notes

Follow-up Tasks

How to test

codecov[bot] commented 1 year ago

Codecov Report

Merging #61 (f51531e) into main (83c5902) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #61   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files           6        6           
  Lines          91       91           
=======================================
  Hits           90       90           
  Misses          1        1           
Files Changed Coverage Δ
lib/openfeature/sdk/configuration.rb 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more