open-feature / ruby-sdk

Ruby implementation of the OpenFeature SDK
https://openfeature.dev
Apache License 2.0
25 stars 9 forks source link

chore(deps): update codecov/codecov-action digest to c4cf8a4 #64

Closed renovate[bot] closed 1 year ago

renovate[bot] commented 1 year ago

Mend Renovate

This PR contains the following updates:

Package Type Update Change
codecov/codecov-action action digest c9e4b73 -> c4cf8a4

Configuration

πŸ“… Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

β™» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

πŸ”• Ignore: Close this PR and you won't be reminded about this update again.



This PR has been generated by Mend Renovate. View repository job log here.

codecov[bot] commented 1 year ago

Codecov Report

Merging #64 (7b64024) into main (8b17e0f) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #64   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files           6        6           
  Lines          91       91           
=======================================
  Hits           90       90           
  Misses          1        1           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

technicalpickles commented 1 year ago

Looks like we are getting failures:

info - 2023-09-13 10:01:14,118 -- ci service found: github-actions
debug - 2023-09-13 10:01:14,119 -- versioning system found: <class 'codecov_cli.helpers.versioning_systems.GitVersioningSystem'>
debug - 2023-09-13 10:01:14,119 -- No codecov_yaml found
debug - 2023-09-13 10:01:14,124 -- Starting create commit process --- {"commit_sha": "925451b3d1897babffb25183d04a072795f8c296", "parent_sha": null, "pr": "64", "branch": "renovate/codecov-codecov-action-digest", "slug": "open-feature/ruby-sdk", "token": null, "service": "github", "enterprise_url": null}
Error: Codecov token not found. Please provide Codecov token with -t flag.

If it is the token missing, makes me wonder how it worked at all πŸ€”

toddbaert commented 1 year ago

Looks like we are getting failures:

info - 2023-09-13 10:01:14,118 -- ci service found: github-actions
debug - 2023-09-13 10:01:14,119 -- versioning system found: <class 'codecov_cli.helpers.versioning_systems.GitVersioningSystem'>
debug - 2023-09-13 10:01:14,119 -- No codecov_yaml found
debug - 2023-09-13 10:01:14,124 -- Starting create commit process --- {"commit_sha": "925451b3d1897babffb25183d04a072795f8c296", "parent_sha": null, "pr": "64", "branch": "renovate/codecov-codecov-action-digest", "slug": "open-feature/ruby-sdk", "token": null, "service": "github", "enterprise_url": null}
Error: Codecov token not found. Please provide Codecov token with -t flag.

If it is the token missing, makes me wonder how it worked at all πŸ€”

@technicalpickles

Let me look into this.

The token isn't really missing (there's clearly successful runs in main). I've seen this before, and it seems to happen when we fire too many requests to codecov. I think it's just rate limiting that's very poorly reported.

One thing we could do is not run codecov in the matrix (to avoid running it so many times). It can just be run once. I'll probably make that change.

toddbaert commented 1 year ago

Fixed with https://github.com/open-feature/ruby-sdk/pull/68

renovate[bot] commented 1 year ago

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for the codecov/codecov-action c4cf8a4 update again.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.