chore: Update Rubocop and pull in recommended plugins

maxveldink commented 12 months ago

This PR

While working on some specification work, I noticed that the version of Rubocop was far behind. Further, Rubocop recommended two extensions when running locally that we should consider including.

Updates rubocop and pulls in rubocop-rake and rubocop-rspec. I pessimistically locked to the minor version, as Rubocop is generally safe to have a looser versioning constraint in favor of benefiting from new rules sooner.
Corrected Rubocop violations, either through configuration or minor code changes

Notes

I'll do my best to annotate this PR with the reason behind configuration or code changes; I'm open to discussing any fix here.

One thought I had while working on this is if the project would entertain moving to Standardrb instead of using stock Rubocop. I can add an issue for more discussion, but I am curious about any initial thoughts. Not maintaining an RSpec configuration is nice.

Follow-up Tasks

Created codecov/codecov-action#71

How to test

Clean Rubocop CI run

technicalpickles commented 12 months ago

@toddbaert hmm, it is the same error as https://github.com/open-feature/ruby-sdk/pull/64#issuecomment-1717837383 when trying to report, even with https://github.com/open-feature/ruby-sdk/pull/67

debug - 2023-09-14 00:53:24,761 -- Starting create commit process --- {"commit_sha": "c24ea2244b3606b23931171c81d93bbe9137744c", "parent_sha": null, "pr": "72", "branch": "mveldink/update-rubocop", "slug": "open-feature/ruby-sdk", "token": null, "service": "github", "enterprise_url": null}
Error: Codecov token not found. Please provide Codecov token with -t flag.
Error: Codecov: Failed to properly create commit: The process '/home/runner/work/_actions/codecov/codecov-action/845c445181131d954f0198d3d0f26242acc0376e/dist/codecov' failed with exit code 1

maxveldink commented 12 months ago

@technicalpickles Great, I added codecov/codecov-action#74 and will take a stab at switching over to see how much work/reformatting would be involved.

toddbaert commented 12 months ago

@technicalpickles the codecov thing ended up being a big can of worms: https://github.com/codecov/feedback/issues/112.

I'm reverting to an older version for now: https://github.com/open-feature/ruby-sdk/pull/75

maxveldink commented 11 months ago

Closing this since codecov/codecov-action#76 was accepted

open-feature / ruby-sdk