open-feature / ruby-sdk

Ruby implementation of the OpenFeature SDK
https://openfeature.dev
Apache License 2.0
25 stars 9 forks source link

chore: Switch to Standardrb instead of stock Rubocop #76

Closed maxveldink closed 1 year ago

maxveldink commented 1 year ago

This PR

Switches from stock Rubocop to Standardrb.

Related Issues

Fixes #74

codecov[bot] commented 1 year ago

Codecov Report

Merging #76 (11205c3) into main (aebb755) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #76   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files           6        6           
  Lines          91       91           
=======================================
  Hits           90       90           
  Misses          1        1           
Files Changed Coverage Δ
lib/openfeature/sdk/api.rb 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

josecolella commented 1 year ago

@maxveldink: thought: Is there a benefit to moving to standardrb over rubocop?

maxveldink commented 1 year ago

The benefit I find with Standard is that it minimizes the number of Rubocop configuration decisions that need to be made. The ruleset they've settled on is fairly binary, and it's typically simple formatting while still getting the nice linting and performance warnings from Rubocop. Whenever I try to use stock Rubocop, I'm constantly fighting with the ruleset, or running into rules that don't apply to the specific project.

Besides that, it's a minor process change that is easy to adopt earlier in a project, which is why I proposed it now.

maxveldink commented 1 year ago

🙏🏻