open-feature / ruby-sdk

Ruby implementation of the OpenFeature SDK
https://openfeature.dev
Apache License 2.0
23 stars 8 forks source link

test: Clarify Requirement 1.1.1 #77

Closed maxveldink closed 11 months ago

maxveldink commented 12 months ago

This PR

I've begun work on the Flag Evaluation API section of the OpenFeature specification. I decided to go from top to bottom (similar to the current unit tests) and ensure there hasn't been any spec drift from the original work done here.

Additionally, I propose maintaining a separate specification set of RSpec tests that correspond 1 to 1 with the specification as written. Currently, we're doing this in line with the unit tests. Still, I foresee situations where we'll want to drive out behavior in unit tests that don't necessarily correspond to a requirement (or when multiple unit tests could satisfy a requirement). Freeing the unit tests of the responsibility of tracking spec compliance seems beneficial.

Finally, I think 1.1.1 can be demonstrated

Follow-up Tasks

I am working on each requirement in the Flag Evaluation API from spec version 0.7.0 and will have PRs this week.

How to test

There is no change to current behavior; a passing RSpec suite should be sufficient.

codecov[bot] commented 12 months ago

Codecov Report

Merging #77 (c1c95a9) into main (f3e9553) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #77   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files           6        6           
  Lines          91       91           
=======================================
  Hits           90       90           
  Misses          1        1           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

maxveldink commented 12 months ago

@mschoenlaub Good call on using conventional commits; I don't in my day job and really should do that everywhere πŸ˜‚ Also fixed up the Rubocop issue as well.

maxveldink commented 11 months ago

@josecolella @technicalpickles Any chance we can get some πŸ‘€ on this πŸ™πŸ»

maxveldink commented 11 months ago

@josecolella Agreed, removed πŸ™πŸ»