codecov[bot]
commented
1 year ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
2d89570) 99.22% compared to head (f65650d) 99.25%.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #78 +/- ## ========================================== + Coverage 99.22% 99.25% +0.02% ========================================== Files 11 11 Lines 129 134 +5 ========================================== + Hits 128 133 +5 Misses 1 1 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
maxveldink
beeme1mr
toddbaert
This PR
Note that this is built off of #77 and will not have that base commit if that commit is accepted.
initandshutdownmethod. I believe we want to leave the defaultinitializebehavior alone in Ruby to satisfy this requirement. This means someone can initialize a Provider instance (and use whatever construction logic there is) and define aninitmethod invoked when the provider is set.providerwriter method onConfigurationwith the behavior required for this requirement. In the following Requirement, which introduced named providers, we should consider renaming this toset_providerorregister_provideror something similar, as there will be an additional argument that would be an unexpected writer signature. That will be a breaking change and is not strictly required for this requirement, so I decided to defer that.Follow-up Tasks
I plan on continuing to implement the flag evaluation API in subsequent PRs.
How to test
Ensure that providers can still be set while configuring OpenFeature. You can play around with a stub Provider that implements
initandshutdownto verify those are also called as expected.