Closed maxveldink closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
2d89570
) 99.22% compared to head (f65650d
) 99.25%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@technicalpickles Apologies for the multi-month delay here; just wrapped up paternity leave! Will review the comments and respond/push some fixes today or tomorrow.
@technicalpickles @josecolella Bumping this PR to see if you all might have any time to review it this week 🙏🏻
Hey @toddbaert, could you please take a quick look at this pr to unblock @maxveldink?
@maxveldink @beeme1mr I'll review this today.
This PR
Note that this is built off of #77 and will not have that base commit if that commit is accepted.
init
andshutdown
method. I believe we want to leave the defaultinitialize
behavior alone in Ruby to satisfy this requirement. This means someone can initialize a Provider instance (and use whatever construction logic there is) and define aninit
method invoked when the provider is set.provider
writer method onConfiguration
with the behavior required for this requirement. In the following Requirement, which introduced named providers, we should consider renaming this toset_provider
orregister_provider
or something similar, as there will be an additional argument that would be an unexpected writer signature. That will be a breaking change and is not strictly required for this requirement, so I decided to defer that.Follow-up Tasks
I plan on continuing to implement the flag evaluation API in subsequent PRs.
How to test
Ensure that providers can still be set while configuring OpenFeature. You can play around with a stub Provider that implements
init
andshutdown
to verify those are also called as expected.