codecov[bot]
commented
11 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.39%. Comparing base (
25680a4) to head (14b7791).
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #80 +/- ## ======================================= Coverage 99.39% 99.39% ======================================= Files 12 12 Lines 164 166 +2 ======================================= + Hits 163 165 +2 Misses 1 1 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
maxveldink
beeme1mr
This PR
Only the last four commits will be merged in with this PR. The others are waiting on #77 and #78.
API.provider=(provider)toAPI.set_provider(provider, domain: nil)to better adhere to the specification. I decided to move away from theattr_writernaming convention as thedomainparameter would be surprising. I would love others' thoughts on this.nilas the key. The other option I tried here was to store@default_providerin addition to the hash, but this approach was simpler to the slight detriment of readability.API.providerto receivedomainas a keyword argument. If no domain is provided, it will return the default provider. This is backward compatible.Follow-up Tasks
In subsequent PRs, I'll continue on the flag evaluation specifications.
How to test
Open a console and play around with the
set_providermethod on the API. If no name is provided, the default provider will be replaced. If a name is provided, the provider will be registered using that name. If the same name is provided, the provider will be overridden.