I think this is a small miss. We didn't explicitly note that errors in a before hook should mean evaluation does not proceed and the default is returned (we did mention error hooks should be triggered, so this could be surmised, but I think this addition makes sense).
I updated a graphic accordingly.
One question is if we should add a 4.4.8 that explicitly mentions the provider should not be called in this case... this might be a good idea, since if an implementation still calls the provider (despite returning the default), there may be side-effects in the flag evaluation service that have incorrect data due to a misbehaving before hook.
I think this is a small miss. We didn't explicitly note that errors in a before hook should mean evaluation does not proceed and the default is returned (we did mention error hooks should be triggered, so this could be surmised, but I think this addition makes sense).
I updated a graphic accordingly.
One question is if we should add a
4.4.8
that explicitly mentions the provider should not be called in this case... this might be a good idea, since if an implementation still calls the provider (despite returning the default), there may be side-effects in the flag evaluation service that have incorrect data due to a misbehaving before hook.