search

open-feature / spec

OpenFeature specification
https://openfeature.dev
Apache License 2.0
597 stars 35 forks source link

Removed EvaluationOptions from FeatureProvider method signatures #134

Closed james-milligan closed 1 year ago

james-milligan commented 1 year ago

BREAKING CHANGE

https://github.com/open-feature/spec/issues/133

toddbaert commented 1 year ago

@beeme1mr this is a breaking change (though a minor one)... I know we're not using release plz here, but do we need to annotate the title at all? Should we be validating titles?

beeme1mr commented 1 year ago

@james-milligan, can you mention that this is a breaking change in the PR comment? I'll make sure to include that information on the release notes.

beeme1mr commented 1 year ago

We have approval but let's wait to merge this until tomorrow (Aug 25th, 2022) to give others a chance to provide feedback.