search

open-feature / spec

OpenFeature specification
https://openfeature.dev
Apache License 2.0
597 stars 35 forks source link

chore: section clarity, harden API, providers #149

Closed toddbaert closed 1 year ago

toddbaert commented 1 year ago

Marking Evaluation API and Providers hardening and a few non-functional changes here that improve structure.

specifically:

An alternative to marking all of provider and evaluation API as hardening would be just marking all existing sections therein as hardening, which might be better since we'd have to do that anyway if we added a new experimental section.

see: https://github.com/open-feature/spec/issues/146 for more on release goals.

toddbaert commented 1 year ago

Changing the spec version numbers may require numerous changes to tests in various SDKs. That doesn't necessary mean we can make the change but we should be aware of the impact.

100%. I know this changes some tests, but this change should actually reduce such thrashing in the future and makes things more consistent. Provider was the only section where the requirements didn't have 3 decimal places.

toddbaert commented 1 year ago

An alternative to marking all of provider and evaluation API as hardening would be just marking all existing sections therein as hardening, which might be better since we'd have to do that anyway if we added a new experimental section.

toddbaert commented 1 year ago

@justinabrahms do you have any objections to this? (I volunteer to absorb the test-renumbering in the java-sdk)