open-feature / spec

OpenFeature specification
https://openfeature.dev
Apache License 2.0
597 stars 35 forks source link

Fix usage of wrong type instead of resolution details #161

Closed humb1t closed 1 year ago

humb1t commented 1 year ago

Evaluation details and flag evaluation names usages for resolution details type were fixed.

Signed-off-by: Nikita Bishonen git@bshn.rs

This PR

In documentation regarding Provider different names were used instead of resolution details. This PR removes wrong or out of date names.

Related Issues

Notes

Follow-up Tasks

How to test

toddbaert commented 1 year ago

@humb1t thanks!

This seems like a good editorial change. At some point the structure's name was changed I think, and we missed these. Most SDKs (JS, Go, .NET) reference this structure by the name in the proposed change. Java uses ProviderEvaluation for the provider method return type, but that doesn't match the existing name exactly either, so overall this should reduce confusion.

toddbaert commented 1 year ago

@humb1t could you run make parse as well? This will update the specificataion.json with your changes, which you should commit as well.

beeme1mr commented 1 year ago

Hi @humb1t, thanks for the PR. Would you be able update the JSON by running make parse? It would be great to get this change into the spec.

beeme1mr commented 1 year ago

Hi @humb1t, would you be able to run the json synchronizer and resolve Todd's comment?

toddbaert commented 1 year ago

@humb1t I've pushed a commit to your branch that updates the JSON. I hope you don't mind.

humb1t commented 1 year ago

Thank you a lot @toddbaert - had a really tough times and glad that you helped with merging this PR 💜