Closed toddbaert closed 10 months ago
As long as we change the signature to api.getClient(String namespace)
, then it seems fine to me?
As long as we change the signature to
api.getClient(String namespace)
, then it seems fine to me?
Ya, I think we'd basically do that everywhere: name
-> namespace
as long as there's a general agreement this is actually an improvement.
I think scope
is also a good candidate. For example, a scoped client
or a scoped provider
where scope is a string
. But I am also fine with namespace
I agree that something other than name is good. I do have a bit of a concern about namespace/scope, which is when I hear namespace in this context I think of something like namespace:flagKey
(routing:useV2
).
Probably doesn't matter, as long as the non-normative text is illustrative enough.
I agree that something other than name is good. I do have a bit of a concern about namespace/scope, which is when I hear namespace in this context I think of something like
namespace:flagKey
(routing:useV2
).
hmm, I agree.
Closing this for now. This seems to be well-enough understood.
Named client / provider mapping is a useful and important concept. I also think the spec only does the bare minimum in explaining it. I'd like to propose two things:
Particularly interested in your thoughts on the namespace proposal @justinabrahms . I think regardless we can add more non-normative text.
cc @thomaspoignant @kinyoklion @beeme1mr @lukas-reining @benjiro