search

open-feature / spec

OpenFeature specification
https://openfeature.dev
Apache License 2.0
779 stars 36 forks source link

chore: add multi provider appendix #264

Closed ajwootto closed 5 months ago

ajwootto commented 5 months ago

This PR

toddbaert commented 5 months ago

I would recommend we add this to included-utilities, since to me that's what this is.

@beeme1mr @Kavindu-Dodan @lukas-reining @thomaspoignant what do you guys think? Should this be separate?

lukas-reining commented 5 months ago

I would recommend we add this to included-utilities, since to me that's what this is.

@beeme1mr @Kavindu-Dodan @lukas-reining @thomaspoignant what do you guys think? Should this be separate?

Yes, I also thought about this in the initial discussion @toddbaert. I would like if it was there as is fits great! The only question I have is how to fit it in there as it is quite large.

toddbaert commented 5 months ago

I would recommend we add this to included-utilities, since to me that's what this is. @beeme1mr @Kavindu-Dodan @lukas-reining @thomaspoignant what do you guys think? Should this be separate?

Yes, I also thought about this in the initial discussion @toddbaert. I would like if it was there as is fits great! The only question I have is how to fit it in there as it is quite large.

I think it's fine just to have it as another heading. We can add some collapsible sections if we want.

ajwootto commented 5 months ago

@toddbaert I moved it to the appendix A section, how's it look in there?

toddbaert commented 5 months ago

@toddbaert I moved it to the appendix A section, how's it look in there?

@ajwootto looks great! I can't edit your branch, so I've made a small PR which fixes the lint errors: https://github.com/DevCycleHQ-Sandbox/spec/pull/1. Please merge this into your branch and I'll then merge this PR.

toddbaert commented 5 months ago

Thanks!