open-feature / spec

OpenFeature specification
https://openfeature.dev
Apache License 2.0
639 stars 34 forks source link

Add provider spec #41

Closed toddbaert closed 2 years ago

toddbaert commented 2 years ago

Added provider spec, with minor associated changes to the existing flag-evaluation spec file.

moredip commented 2 years ago

Do we want to specify any semantics around how a provider should handle transient errors on their side. Like if there's a network connectivity issue, should to provider immediately fail, or have a retry/fallback mechanism.

One option is to leave this entirely unspecified and up to each provider. Another would be to give a provider implementer some guidance or suggestions - e.g. make a best effort to handle transient failure, but don't hang evaluation for "a long time" (whatever that means).

toddbaert commented 2 years ago

Do we want to specify any semantics around how a provider should handle transient errors on their side. Like if there's a network connectivity issue, should to provider immediately fail, or have a retry/fallback mechanism.

One option is to leave this entirely unspecified and up to each provider. Another would be to give a provider implementer some guidance or suggestions - e.g. make a best effort to handle transient failure, but don't hang evaluation for "a long time" (whatever that means).

This might be relevant to the "event" discussion. Most SDKs have readiness events, etc. We could build an events API which might cover both cases.

I think for now, I would err on the side of not defining this until we need to - but I'm not sure. If there's a pressing use-case, we can talk more about it.

toddbaert commented 2 years ago

@moredip any additional concerns after my updates to your comments?

I think we have 2 open questions represented here, which I may create other issues for:

I don't think either of these are a blocker for this, but let me know if you disagree.

moredip commented 2 years ago

@moredip any additional concerns after my updates to your comments?

Nope, I think it's good

toddbaert commented 2 years ago

Squashed, added co-authors.