search

open-feature / spec

OpenFeature specification
https://openfeature.dev
Apache License 2.0
612 stars 35 forks source link

Two spec-compliant SDKs #86

Closed justinabrahms closed 2 years ago

justinabrahms commented 2 years ago

There are unknown unknowns within the spec. We'll know more through SDK implementation. As such, a barrier to a true alpha release would be to get 2 spec-compliant SDKs. I think java is a reasonable proxy for the typed side of things. Python or Javascript would be a good second candidate.

matthewelwell commented 2 years ago

We have a python implementation in the works here if it helps.

justinabrahms commented 2 years ago

Sounds good to me. Once you hit spec compliance with the parts of the spec in scope for alpha.. check the box. :)

On Fri, May 27, 2022, at 9:31 AM, Matthew Elwell wrote:

We have a python implementation in the works here https://github.com/open-feature/python-sdk/pull/1 if it helps.

— Reply to this email directly, view it on GitHub https://github.com/open-feature/spec/issues/86#issuecomment-1139778173, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAA6DIKTDEZQJY62OTRZ2DVMD2GRANCNFSM5XEUMRCA. You are receiving this because you were assigned.Message ID: @.***>

weyert commented 2 years ago

Are there plans to also support browser JavaScript beside node?

justinabrahms commented 2 years ago

@weyert Yes. We think there will be a single SDK, but the providers themselves will differ. I suspect help is welcome there if you're interested in getting involved.

toddbaert commented 2 years ago

@justinabrahms I'm definitely in favor of having the Node SDK released as an alpha. I propose a checklist for alpha candidates, as we discussed. Ideally it could be included in the respective SDK readme:

SDK alpha checklist:

justinabrahms commented 2 years ago

I support this.

On Thu, Jun 23, 2022, at 2:48 PM, Todd Baert wrote:

@justinabrahms https://github.com/justinabrahms I'm definitely in favor of having the Node SDK released as an alpha. I propose a checklist for alpha candidates, as we discussed. Ideally it could be included in the respective SDK readme:

SDK alpha checklist:

  • compliant with current spec
  • contains test suite which verifies behavior consistent with spec
  • contains test suite with reasonable coverage
  • automatic publishing to official public artifact repository under OpenFeature namespace, if applicable
  • has a readme outlining basic installation and usage

— Reply to this email directly, view it on GitHub https://github.com/open-feature/spec/issues/86#issuecomment-1164804741, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAA6DNTOVFXYWIXIKWAE4DVQS5QFANCNFSM5XEUMRCA. You are receiving this because you were mentioned.Message ID: @.***>

toddbaert commented 2 years ago

Here's what I've put in the Node.JS readme, just a rephrase of above:

- [x] spec compliant
- [x] contains test suite which verifies behavior consistent with spec
- [x] contains test suite with reasonable coverage
- [x] automated publishing
- [ ] comprehensive readme
toddbaert commented 2 years ago

cc @davejohnston @dabeeeenster @ajhelsby

cc @justinabrahms I'm OK to close this now if you agree. I'm going to work a bit on the Node.JS readme, and also https://github.com/open-feature/spec/issues/101, which is related, and should benefit all the SDKs.