search

open-feature / spec

OpenFeature specification
https://openfeature.dev
Apache License 2.0
612 stars 35 forks source link

Markdown lint #87

Closed justinabrahms closed 2 years ago

justinabrahms commented 2 years ago

Refs https://github.com/open-feature/spec/issues/36

May close it out entirely, depending on how strongly we feel about auto-TOC.

If we want that, we might explore this: https://github.com/marketplace/actions/toc-generator. The other options I saw didn't seem the greatest. (pandoc doesn't pass lint, for example)

justinabrahms commented 2 years ago

Looks like wrapping is causing our rendering to not have spaces in the json. I'll need to look into that.

justinabrahms commented 2 years ago

I don't much care of the line lengths, but we should pick some standard. Happy to pick something else. 🤷‍♂️

On Sat, May 28, 2022, at 12:36 PM, Oleg Nenashev wrote:

@.**** approved this pull request.

I would not enforce such short line breaks, but otherwise looks ok

— Reply to this email directly, view it on GitHub https://github.com/open-feature/spec/pull/87#pullrequestreview-988550233, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAA6DICKT46ROKQSM6H3P3VMJYUZANCNFSM5XFXQGFQ. You are receiving this because you authored the thread.Message ID: @.***>

justinabrahms commented 2 years ago

Merging now so as to not cause a million merge conflicts for someone else. If we want to change the line length, that seems fine to me.