open-formulieren / open-forms-sdk

A Javascript SDK for Open Forms
https://open-forms.readthedocs.io/en/stable/developers/sdk/index.html
Other
2 stars 6 forks source link

Validation error positioning #466

Open sergei-maertens opened 1 year ago

sergei-maertens commented 1 year ago

NL DS leans towards putting validation errors above the field (consistent with the gov.uk approach), while the Open Forms theme puts them below. We want to avoid users having to override the container/wrapper component layout just to achieve this, as there should be CSS-only solutions.

Possible options:

vaszig commented 10 months ago

Open Forms is now showing the errors below the field and the same is happening for Utrecht.

https://open-formulieren.github.io/open-forms-sdk/?path=/story/pure-react-components-forms-textfield--validation-error

https://nl-design-system.github.io/utrecht/storybook/?path=/story/react_react-form-field--form-field-textbox

sergei-maertens commented 8 months ago

Discussed with NL DS - the intent is indeed that the validation error is above the field, but their own storybook gives incorrect examples. They will update those components/examples.