codecov[bot]
commented
1 year ago Codecov Report
Patch coverage: 63.63% and project coverage change: +0.58% :tada:
Comparison is base (
2d4b040) 48.64% compared to head (13fc874) 49.23%.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #528 +/- ## ========================================== + Coverage 48.64% 49.23% +0.58% ========================================== Files 199 199 Lines 3571 3577 +6 Branches 645 646 +1 ========================================== + Hits 1737 1761 +24 + Misses 1664 1643 -21 - Partials 170 173 +3 ``` | [Files Changed](https://app.codecov.io/gh/open-formulieren/open-forms-sdk/pull/528?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-formulieren) | Coverage Δ | | |---|---|---| | [src/Context.js](https://app.codecov.io/gh/open-formulieren/open-forms-sdk/pull/528?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-formulieren#diff-c3JjL0NvbnRleHQuanM=) | `100.00% <ø> (ø)` | | | [src/components/Form.js](https://app.codecov.io/gh/open-formulieren/open-forms-sdk/pull/528?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-formulieren#diff-c3JjL2NvbXBvbmVudHMvRm9ybS5qcw==) | `30.84% <0.00%> (ø)` | | | [src/components/forms/EmailField/EmailField.js](https://app.codecov.io/gh/open-formulieren/open-forms-sdk/pull/528?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-formulieren#diff-c3JjL2NvbXBvbmVudHMvZm9ybXMvRW1haWxGaWVsZC9FbWFpbEZpZWxkLmpz) | `100.00% <ø> (ø)` | | | [src/components/forms/TextField/TextField.js](https://app.codecov.io/gh/open-formulieren/open-forms-sdk/pull/528?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-formulieren#diff-c3JjL2NvbXBvbmVudHMvZm9ybXMvVGV4dEZpZWxkL1RleHRGaWVsZC5qcw==) | `87.50% <ø> (+62.50%)` | :arrow_up: | | [src/hooks/useGetOrCreateSubmission.js](https://app.codecov.io/gh/open-formulieren/open-forms-sdk/pull/528?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-formulieren#diff-c3JjL2hvb2tzL3VzZUdldE9yQ3JlYXRlU3VibWlzc2lvbi5qcw==) | `8.00% <0.00%> (ø)` | | | [src/components/App.js](https://app.codecov.io/gh/open-formulieren/open-forms-sdk/pull/528?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-formulieren#diff-c3JjL2NvbXBvbmVudHMvQXBwLmpz) | `72.22% <50.00%> (+1.63%)` | :arrow_up: | | [src/data/submissions.js](https://app.codecov.io/gh/open-formulieren/open-forms-sdk/pull/528?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-formulieren#diff-c3JjL2RhdGEvc3VibWlzc2lvbnMuanM=) | `36.36% <100.00%> (ø)` | | | [src/sdk.js](https://app.codecov.io/gh/open-formulieren/open-forms-sdk/pull/528?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-formulieren#diff-c3JjL3Nkay5qcw==) | `98.00% <100.00%> (+0.22%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/open-formulieren/open-forms-sdk/pull/528/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-formulieren):umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Partially closes open-formulieren/open-forms#3322
Two issues at hand here:
form.isAppointmenthandling caused the cancel URL to always redirect to the flow to create a new appointmentformUrlbeing passed to submission creation. This is now normalized base on the SDKbasePathoption (which specifies where a particular form is publicly hosted).The handling of fragment routing in the backend is something that will still require particular attention, I've no idea yet how to do this :cry: