search

open-formulieren / open-forms-sdk

A Javascript SDK for Open Forms
https://open-forms.readthedocs.io/en/stable/developers/sdk/index.html
Other
2 stars 6 forks source link

Handle invalid states when accessing URLs directly #536

Closed sergei-maertens closed 1 year ago

sergei-maertens commented 1 year ago

Classic OWASP thing, fiddling with the URL and trying to bypass checks :)

Closes #508, depends on #535

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.11% :warning:

Comparison is base (9142694) 70.46% compared to head (866b5e9) 70.36%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #536 +/- ## ========================================== - Coverage 70.46% 70.36% -0.11% ========================================== Files 205 205 Lines 4226 4231 +5 Branches 1145 1148 +3 ========================================== - Hits 2978 2977 -1 - Misses 1219 1225 +6 Partials 29 29 ``` | [Files Changed](https://app.codecov.io/gh/open-formulieren/open-forms-sdk/pull/536?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-formulieren) | Coverage Δ | | |---|---|---| | [src/components/appointments/ContactDetailsStep.js](https://app.codecov.io/gh/open-formulieren/open-forms-sdk/pull/536?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-formulieren#diff-c3JjL2NvbXBvbmVudHMvYXBwb2ludG1lbnRzL0NvbnRhY3REZXRhaWxzU3RlcC5qcw==) | `95.83% <100.00%> (+0.27%)` | :arrow_up: | | [src/components/appointments/LocationAndTimeStep.js](https://app.codecov.io/gh/open-formulieren/open-forms-sdk/pull/536?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-formulieren#diff-c3JjL2NvbXBvbmVudHMvYXBwb2ludG1lbnRzL0xvY2F0aW9uQW5kVGltZVN0ZXAuanM=) | `92.00% <100.00%> (+0.33%)` | :arrow_up: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/open-formulieren/open-forms-sdk/pull/536/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-formulieren)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sergei-maertens commented 1 year ago

What's the use of a route if I can't bookmark it or navigate with it?

hmmm OWASP, interesting way of framing it: a backend in the frontend.

So you're saying that HTTP 3XX is now obsolete? :wink: