Closed sergei-maertens closed 1 year ago
Patch coverage: 100.00%
and project coverage change: -0.06%
:warning:
Comparison is base (
dc963be
) 70.27% compared to head (94f907e
) 70.22%. Report is 6 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I don't recognise hash based routing tests, is that something we get for free from some library by setting
REACT_APP_USE_HASH_ROUTING=true
in the env?
It's something we handle ourselves in sdk.js
by selecting a different router:
const createRouter = this.useHashRouting ? createHashRouter : createBrowserRouter;
const router = createRouter(routes, {basename: this.basePath});
so that makes it impossible to test, since we use createMemoryRouter
in tests. I've verified it manually and I suppose that's the best we can do, short of an end-to-end tests with a real backend.
Closes open-formulieren/open-forms#3300