open-formulieren / open-forms-sdk

A Javascript SDK for Open Forms
https://open-forms.readthedocs.io/en/stable/developers/sdk/index.html
Other
2 stars 6 forks source link

[OF#1884] Fine grained custom errors for time components #545

Closed SilviaAmAm closed 1 year ago

SilviaAmAm commented 1 year ago

Fixes https://github.com/open-formulieren/open-forms/issues/1884 Screenshot from 2023-09-04 15-17-57

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 84.21% and project coverage change: -14.91% :warning:

Comparison is base (42a8a63) 70.15% compared to head (7b720df) 55.24%.

:exclamation: Current head 7b720df differs from pull request most recent head 99732a7. Consider uploading reports for the commit 99732a7 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #545 +/- ## =========================================== - Coverage 70.15% 55.24% -14.91% =========================================== Files 206 202 -4 Lines 4248 3707 -541 Branches 1150 670 -480 =========================================== - Hits 2980 2048 -932 - Misses 1235 1469 +234 - Partials 33 190 +157 ``` | [Files Changed](https://app.codecov.io/gh/open-formulieren/open-forms-sdk/pull/545?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-formulieren) | Coverage Δ | | |---|---|---| | [src/formio/validators/MinMaxTimeValidator.js](https://app.codecov.io/gh/open-formulieren/open-forms-sdk/pull/545?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-formulieren#diff-c3JjL2Zvcm1pby92YWxpZGF0b3JzL01pbk1heFRpbWVWYWxpZGF0b3IuanM=) | `90.90% <84.21%> (+3.95%)` | :arrow_up: | ... and [130 files with indirect coverage changes](https://app.codecov.io/gh/open-formulieren/open-forms-sdk/pull/545/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-formulieren)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.