open-formulieren / open-forms-sdk

A Javascript SDK for Open Forms
https://open-forms.readthedocs.io/en/stable/developers/sdk/index.html
Other
2 stars 6 forks source link

:lipstick: Fix width of progress indicator #550

Closed sergei-maertens closed 1 year ago

sergei-maertens commented 1 year ago

The bar was not taking up full width due to the negative margin-left and margin-right values, combined with the width: 100% of the parent. Setting the width to calc(100% + 2 * margin) results in a horizontal scrollbar, but unsetting the width fixes the styling on mobile while not destroying it on desktop.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +0.02% :tada:

Comparison is base (1f47894) 70.60% compared to head (34c9a37) 70.63%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #550 +/- ## ========================================== + Coverage 70.60% 70.63% +0.02% ========================================== Files 206 206 Lines 4263 4263 Branches 1154 1154 ========================================== + Hits 3010 3011 +1 Misses 1222 1222 + Partials 31 30 -1 ``` [see 5 files with indirect coverage changes](https://app.codecov.io/gh/open-formulieren/open-forms-sdk/pull/550/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-formulieren)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sergei-maertens commented 1 year ago

Backports: 994ecc36249bd334c4cfa540659d92fec9190a77, a66e1b99cbf0cc878e6d96b47ea0e9cb484762f6 and c9612d2962cb05b75e3b59600cacaa2d2899fd96