search

open-formulieren / open-forms-sdk

A Javascript SDK for Open Forms
https://open-forms.readthedocs.io/en/stable/developers/sdk/index.html
Other
2 stars 6 forks source link

[OF#3383] Refactor phone number validation #553

Closed vaszig closed 1 year ago

vaszig commented 1 year ago

Fixes open-formulieren/open-forms#3383

codecov[bot] commented 1 year ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (0f61b0f) 55.49% compared to head (25599dd) 70.83%. Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #553 +/- ## =========================================== + Coverage 55.49% 70.83% +15.34% =========================================== Files 203 209 +6 Lines 3743 4300 +557 Branches 679 1162 +483 =========================================== + Hits 2077 3046 +969 + Misses 1475 1219 -256 + Partials 191 35 -156 ``` | [Files](https://app.codecov.io/gh/open-formulieren/open-forms-sdk/pull/553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-formulieren) | Coverage Δ | | |---|---|---| | [.../jstests/formio/components/fixtures/phonenumber.js](https://app.codecov.io/gh/open-formulieren/open-forms-sdk/pull/553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-formulieren#diff-c3JjL2pzdGVzdHMvZm9ybWlvL2NvbXBvbmVudHMvZml4dHVyZXMvcGhvbmVudW1iZXIuanM=) | `100.00% <100.00%> (ø)` | | | [src/jstests/formio/validators/mocks.js](https://app.codecov.io/gh/open-formulieren/open-forms-sdk/pull/553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-formulieren#diff-c3JjL2pzdGVzdHMvZm9ybWlvL3ZhbGlkYXRvcnMvbW9ja3MuanM=) | `100.00% <100.00%> (ø)` | | | [src/formio/validators/plugins.js](https://app.codecov.io/gh/open-formulieren/open-forms-sdk/pull/553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-formulieren#diff-c3JjL2Zvcm1pby92YWxpZGF0b3JzL3BsdWdpbnMuanM=) | `80.95% <78.94%> (+68.95%)` | :arrow_up: | ... and [129 files with indirect coverage changes](https://app.codecov.io/gh/open-formulieren/open-forms-sdk/pull/553/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-formulieren)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.