search

open-formulieren / open-forms-sdk

A Javascript SDK for Open Forms
https://open-forms.readthedocs.io/en/stable/developers/sdk/index.html
Other
2 stars 6 forks source link

[OF#3510] Fix overlapping address under map component #562

Closed vaszig closed 1 year ago

vaszig commented 1 year ago

Fixes open-formulieren/open-forms#3510

vaszig commented 1 year ago

I haven't managed to solve this by defining different position in the elements. I added the flex property to the map and below you can see the results:

Desktop

desktop

Mobile

mobile

codecov[bot] commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (42886b8) 71.31% compared to head (cadc6d6) 70.78%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #562 +/- ## ========================================== - Coverage 71.31% 70.78% -0.54% ========================================== Files 209 209 Lines 4306 4306 Branches 1164 1164 ========================================== - Hits 3071 3048 -23 - Misses 1203 1222 +19 - Partials 32 36 +4 ``` [see 5 files with indirect coverage changes](https://app.codecov.io/gh/open-formulieren/open-forms-sdk/pull/562/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-formulieren)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sergei-maertens commented 1 year ago

Backport: a2193e6f3efc057161f26f374a97942f14c4e3ae