open-formulieren / open-forms-sdk

A Javascript SDK for Open Forms
https://open-forms.readthedocs.io/en/stable/developers/sdk/index.html
Other
2 stars 6 forks source link

Implement cursor start/end on Home/End keypress #565

Closed sergei-maertens closed 1 year ago

sergei-maertens commented 1 year ago

Closes #437

Solution taken from react-select issue/discussion.

There is some ambiguity on what the behaviour should be on MacOS, but due to lack of appropriate device we're leaving that as it is, for now.

codecov[bot] commented 1 year ago

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (2787793) 70.87% compared to head (5123f46) 71.15%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #565 +/- ## ========================================== + Coverage 70.87% 71.15% +0.27% ========================================== Files 209 209 Lines 4306 4319 +13 Branches 1164 1171 +7 ========================================== + Hits 3052 3073 +21 + Misses 1219 1214 -5 + Partials 35 32 -3 ``` | [Files](https://app.codecov.io/gh/open-formulieren/open-forms-sdk/pull/565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-formulieren) | Coverage Δ | | |---|---|---| | [src/components/forms/SelectField/SelectField.js](https://app.codecov.io/gh/open-formulieren/open-forms-sdk/pull/565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-formulieren#diff-c3JjL2NvbXBvbmVudHMvZm9ybXMvU2VsZWN0RmllbGQvU2VsZWN0RmllbGQuanM=) | `75.71% <15.38%> (-13.76%)` | :arrow_down: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/open-formulieren/open-forms-sdk/pull/565/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-formulieren)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.