open-formulieren / open-forms-sdk

A Javascript SDK for Open Forms
https://open-forms.readthedocs.io/en/stable/developers/sdk/index.html
Other
2 stars 6 forks source link

[#3647] Prevent invalid time from crashing form #609

Closed SilviaAmAm closed 9 months ago

SilviaAmAm commented 9 months ago

Fixes open-formulieren/open-forms#3647

The behaviour is still not right: the validation only triggers on the 'on blur' event (so the check logic call happens with invalid data). But the backend doesn't crash anymore (with this fix https://github.com/open-formulieren/open-forms/pull/3670) so the form doesn't crash.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b405923) 72.36% compared to head (b4d8cf5) 72.41%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #609 +/- ## ========================================== + Coverage 72.36% 72.41% +0.05% ========================================== Files 214 214 Lines 4335 4343 +8 Branches 1160 1162 +2 ========================================== + Hits 3137 3145 +8 Misses 1159 1159 Partials 39 39 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sergei-maertens commented 9 months ago

Backports: