search

open-formulieren / open-forms-sdk

A Javascript SDK for Open Forms
https://open-forms.readthedocs.io/en/stable/developers/sdk/index.html
Other
2 stars 6 forks source link

Message of `LabelContent` shouldn't rely on `requiredFieldsWithAsterisk` #613

Closed Viicos closed 10 months ago

Viicos commented 10 months ago

The current definition:

https://github.com/open-formulieren/open-forms-sdk/blob/b1210cd7ed9d2415d2554798bd617d8aad1fed92/src/components/forms/Label.js#L12-L28

uses requiredFieldsWithAsterisk to determine if not required should be appended to the label. I think it makes more sense to only rely on isRequired.

sergei-maertens commented 10 months ago

Discussed, there was a lack in understanding of this configuration parameter :-)