search

open-formulieren / open-forms-sdk

A Javascript SDK for Open Forms
https://open-forms.readthedocs.io/en/stable/developers/sdk/index.html
Other
2 stars 6 forks source link

[OF#3671] Fix max date validation when current included #616

Closed vaszig closed 10 months ago

vaszig commented 10 months ago

Fixes open-formulieren/open-forms#3671

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (29cbaa3) 72.71% compared to head (4623e84) 73.72%. Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #616 +/- ## ========================================== + Coverage 72.71% 73.72% +1.01% ========================================== Files 214 214 Lines 4343 4343 Branches 1162 1162 ========================================== + Hits 3158 3202 +44 + Misses 1146 1102 -44 Partials 39 39 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vaszig commented 10 months ago

Tried to add a story-test for max date but same problem as for the min date. Can't find the way to make this pass automatically (it does show the error when we enter manually a wrong date).

sergei-maertens commented 10 months ago

Backports: 67678ae84504b4cea77a0ba2169d448721e977fc

The validator code is not present in stable/1.5.x or older.