open-formulieren / open-forms-sdk

A Javascript SDK for Open Forms
https://open-forms.readthedocs.io/en/stable/developers/sdk/index.html
Other
2 stars 6 forks source link

[OF#180] Add a completion callback to the SDK #622

Closed SilviaAmAm closed 9 months ago

SilviaAmAm commented 10 months ago

Fixes open-formulieren/open-forms#180 (partly)

This can be then used by the page embedding the SDK to show the govmetric feedback button on the summary page

codecov[bot] commented 10 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (c4ea5f8) 73.02% compared to head (c844956) 73.36%.

Files Patch % Lines
src/components/Summary/SubmissionSummary.js 60.00% 1 Missing and 1 partial :warning:
src/api-mocks/submissions.js 50.00% 1 Missing :warning:
src/sdk.js 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #622 +/- ## ========================================== + Coverage 73.02% 73.36% +0.34% ========================================== Files 219 219 Lines 4474 4483 +9 Branches 1186 1187 +1 ========================================== + Hits 3267 3289 +22 + Misses 1168 1152 -16 - Partials 39 42 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.