search

open-formulieren / open-forms-sdk

A Javascript SDK for Open Forms
https://open-forms.readthedocs.io/en/stable/developers/sdk/index.html
Other
2 stars 6 forks source link

[#614] Use `leaflet-tools` #624

Closed Viicos closed 9 months ago

Viicos commented 10 months ago

Fixes #614

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (20091ae) 73.02% compared to head (0764db1) 73.44%.

:exclamation: Current head 0764db1 differs from pull request most recent head cf2fe87. Consider uploading reports for the commit cf2fe87 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #624 +/- ## ========================================== + Coverage 73.02% 73.44% +0.42% ========================================== Files 219 218 -1 Lines 4475 4467 -8 Branches 1186 1186 ========================================== + Hits 3268 3281 +13 + Misses 1168 1147 -21 Partials 39 39 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Viicos commented 9 months ago

Hitting a weird test failure. Might be related: https://github.com/Leaflet/Leaflet/issues/6416#issuecomment-1360369989

sergei-maertens commented 9 months ago

Hitting a weird test failure. Might be related: Leaflet/Leaflet#6416 (comment)

Try updating leaflet to the latest version, this code works in the new form builder :thinking:

Viicos commented 9 months ago

Try updating leaflet to the latest version, this code works in the new form builder 🤔

tried with no eval

Viicos commented 9 months ago

Regarding sergei's questions: he asked if it was possible to get rid of the constants module, but the current form builder does not set default values for the center. So did a bit of cleanup but still keeping the module