search

open-formulieren / open-forms-sdk

A Javascript SDK for Open Forms
https://open-forms.readthedocs.io/en/stable/developers/sdk/index.html
Other
2 stars 6 forks source link

Refactor submission summary to use NL DS components #626

Closed sergei-maertens closed 9 months ago

sergei-maertens commented 9 months ago

Depends on #625 for the visual regression testing Depends on https://github.com/open-formulieren/design-tokens/pull/46 for the design tokens

Closes #471

This refactors our summary components to re-use the NL DS data list components, for better semantic HTML & theming support through design tokens.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1a9e6b7) 72.48% compared to head (f7576cd) 72.47%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #626 +/- ## ========================================== - Coverage 72.48% 72.47% -0.01% ========================================== Files 214 214 Lines 4343 4342 -1 Branches 1162 1162 ========================================== - Hits 3148 3147 -1 Misses 1156 1156 Partials 39 39 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.