search

open-formulieren / open-forms-sdk

A Javascript SDK for Open Forms
https://open-forms.readthedocs.io/en/stable/developers/sdk/index.html
Other
2 stars 6 forks source link

[OF#3726] Payment views rework #628

Closed SilviaAmAm closed 8 months ago

SilviaAmAm commented 8 months ago

Fixes https://github.com/open-formulieren/open-forms/issues/3726

Needs: https://github.com/open-formulieren/open-forms/pull/3739

Flow: https://watch.screencastify.com/v/Yi8zo6VXxq5AGMdpZqJb

codecov[bot] commented 8 months ago

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (4bfec86) 73.41% compared to head (19df73f) 73.52%.

:exclamation: Current head 19df73f differs from pull request most recent head 3622c59. Consider uploading reports for the commit 3622c59 to get more accurate results

Files Patch % Lines
src/components/Form.js 45.45% 6 Missing :warning:
src/components/postCompletionViews/StartPayment.js 70.58% 5 Missing :warning:
.../components/postCompletionViews/StatusUrlPoller.js 88.46% 2 Missing and 1 partial :warning:
...mponents/postCompletionViews/PostCompletionView.js 88.88% 1 Missing :warning:
...components/postCompletionViews/StartPaymentView.js 88.88% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #628 +/- ## ========================================== + Coverage 73.41% 73.52% +0.10% ========================================== Files 216 219 +3 Lines 4450 4460 +10 Branches 1185 1182 -3 ========================================== + Hits 3267 3279 +12 + Misses 1144 1142 -2 Partials 39 39 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.