open-formulieren / open-forms-sdk

A Javascript SDK for Open Forms
https://open-forms.readthedocs.io/en/stable/developers/sdk/index.html
Other
2 stars 6 forks source link

Improve summary accessibility #631

Closed sergei-maertens closed 7 months ago

sergei-maertens commented 8 months ago

This was mentioned by @Robbert during our latest NL DS chat.

Rather than using aria-describedby I opted for aria-label to get good translatable messages - depending on the language, we can't anticipate how the form-designer provided editStepText properly fits into a sentence strung together from various DOM elements in a particular order.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0d43df2) 73.58% compared to head (f8c64d9) 73.52%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #631 +/- ## ========================================== - Coverage 73.58% 73.52% -0.06% ========================================== Files 219 219 Lines 4474 4472 -2 Branches 1186 1184 -2 ========================================== - Hits 3292 3288 -4 + Misses 1146 1145 -1 - Partials 36 39 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.