Closed SilviaAmAm closed 7 months ago
Attention: 12 lines
in your changes are missing coverage. Please review.
Comparison is base (
42b47c4
) 73.04% compared to head (8845f0b
) 75.12%. Report is 31 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The button seems to appear on the right in the stories:
It is because the AbortionButton
component returns a toolbar. Maybe this doesn't make much sense and it should return a button and then the component using it can add the toolbar :thinking:
Apart from that, if I understand correctly this also simplifies the current onFormAbort / onLogout logic and everything is centralized in one place?
Yes indeed! I tried combining those into one place. There is still the component taking care of saving the submission halfway through that also uses similar code, but I was worried of breaking it, so I didn't refactor it for now.
Extra thought: maybe we should always have an abortion button, also if govmetrics isn't enabled :thinking: Then we could refactor ExistingSubmissionOptions
further
Extra thought: maybe we should always have an abortion button, also if govmetrics isn't enabled 🤔 Then we could refactor
ExistingSubmissionOptions
further
I think it could be great, as a user I would expect an explicit way to abort, without having to close the browser and wonder about what actually happens when I do so
Follow up ticket: https://github.com/open-formulieren/open-forms/issues/3791
Please see the comments on the Chromatic build - there's some empty blank space now that should ideally not be rendered if the abortion button is not relevant.
Also merged the main
branch in stable/2.5.x
now.
Fixes open-formulieren/open-forms#180
Backend: https://github.com/open-formulieren/open-forms/pull/3775