search

open-formulieren / open-forms-sdk

A Javascript SDK for Open Forms
https://open-forms.readthedocs.io/en/stable/developers/sdk/index.html
Other
2 stars 6 forks source link

Make required asterisk theme-independant #640

Closed vjawala closed 7 months ago

vjawala commented 7 months ago

In _formio_component.scss the field-required asterisk is removed because it is handled with the "utrecht-form-label--openforms-required" class. But this class was scoped on the "openforms-theme", meaning it did not work with other themes.

As the showing/hiding of the asterisk is a core functionality I think this css should be scoped on all themes. Styling can be further tweaked in the specific design system.

sergei-maertens commented 7 months ago

Thanks for the contribution!

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (831dd12) 74.85% compared to head (ff47bc4) 74.10%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #640 +/- ## ========================================== - Coverage 74.85% 74.10% -0.75% ========================================== Files 224 224 Lines 4542 4542 Branches 1211 1211 ========================================== - Hits 3400 3366 -34 - Misses 1103 1137 +34 Partials 39 39 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.