search

open-formulieren / open-forms-sdk

A Javascript SDK for Open Forms
https://open-forms.readthedocs.io/en/stable/developers/sdk/index.html
Other
2 stars 6 forks source link

Correctly render `content` component in summary #653

Closed Viicos closed 8 months ago

Viicos commented 8 months ago

Fixes https://github.com/open-formulieren/open-forms/issues/3845

Not sure this is the right solution

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.87%. Comparing base (24e5ebe) to head (eb0ac96). Report is 6 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #653 +/- ## ========================================== - Coverage 74.99% 74.87% -0.13% ========================================== Files 225 225 Lines 4547 4549 +2 Branches 1214 1214 ========================================== - Hits 3410 3406 -4 - Misses 1101 1104 +3 - Partials 36 39 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SilviaAmAm commented 8 months ago

Euhh not sure what I did wrong when reviewing chromatic, but maybe update the stories to show how the content component with style are rendered?

Edit: ah now chromatic shows the comments :smile:

sergei-maertens commented 8 months ago

Backports: