open-formulieren / open-forms-sdk

A Javascript SDK for Open Forms
https://open-forms.readthedocs.io/en/stable/developers/sdk/index.html
Other
2 stars 6 forks source link

[open-formulieren/open-forms#4130] Do not show main url when asking for payment #672

Closed Viicos closed 4 months ago

Viicos commented 4 months ago

Fixes open-formulieren/open-forms#4130

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 55.30%. Comparing base (6b62b74) to head (e9a0c76). Report is 5 commits behind head on main.

Files Patch % Lines
...components/PostCompletionViews/StartPaymentView.js 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #672 +/- ## ========================================== - Coverage 63.64% 55.30% -8.35% ========================================== Files 93 221 +128 Lines 1642 3962 +2320 Branches 427 721 +294 ========================================== + Hits 1045 2191 +1146 - Misses 597 1569 +972 - Partials 0 202 +202 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SilviaAmAm commented 4 months ago

I think that these stories still need updating: src/components/PostCompletionViews/viewsWithPolling.stories.js ?

SilviaAmAm commented 4 months ago

I think that these stories still need updating: src/components/PostCompletionViews/viewsWithPolling.stories.js ?

No, nothing needs to be done for these: these are the confirmation views for after payment