search

open-formulieren / open-forms-sdk

A Javascript SDK for Open Forms
https://open-forms.readthedocs.io/en/stable/developers/sdk/index.html
Other
2 stars 6 forks source link

Fix imports after SBv8 upgrade #676

Closed Viicos closed 3 months ago

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.46%. Comparing base (8f502bb) to head (a928618).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #676 +/- ## ========================================== + Coverage 61.24% 61.46% +0.21% ========================================== Files 225 225 Lines 4126 4126 Branches 849 849 ========================================== + Hits 2527 2536 +9 + Misses 1480 1471 -9 Partials 119 119 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Viicos commented 3 months ago

Did you use a tool for this or go through them by hand? By hand, there's a chance I missed some. But I think setting up eslint or https://biomejs.dev/ would help and would pick up the missing ones if we ever use it

sergei-maertens commented 3 months ago

no I was asking because if there's a tool that I didn't find, I want it :) there's an open issue in the import sort plugin for prettier to apply the grouping, but it hasn't been implemented yet.

I've gone through the same in the form-builder repo and it wasn't much fun