search

open-formulieren / open-forms-sdk

A Javascript SDK for Open Forms
https://open-forms.readthedocs.io/en/stable/developers/sdk/index.html
Other
2 stars 6 forks source link

[open-formulieren/open-forms#4207] Fix styling overflow for select dropdown #679

Closed Viicos closed 3 months ago

Viicos commented 4 months ago

Fixes open-formulieren/open-forms#4207

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.62%. Comparing base (8f502bb) to head (4469401). Report is 12 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #679 +/- ## ========================================== + Coverage 61.24% 61.62% +0.37% ========================================== Files 225 225 Lines 4126 4125 -1 Branches 849 848 -1 ========================================== + Hits 2527 2542 +15 + Misses 1480 1463 -17 - Partials 119 120 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sergei-maertens commented 3 months ago

where is the storybook story for this? I want visual regression tests for this.

Viicos commented 3 months ago

Ok finally this should be ok