open-formulieren / open-forms-sdk

A Javascript SDK for Open Forms
https://open-forms.readthedocs.io/en/stable/developers/sdk/index.html
Other
2 stars 6 forks source link

feat: add custom class to classnames to textfield #682

Closed scar055 closed 2 months ago

scar055 commented 3 months ago

Naar aanleiding van gebruikersonderzoek wil de gemeente Utrecht de breedte van formuliervelden afwisselend maken, met kleinere velden voor korte input.

Deze custom class names willen we gebruiken zodat we een lijst van class names kunnen maken om de breedte van textfields te stylen. Dit willen we doen voor toegankelijkheid.

image

Is er trouwens een manier om de custom class optie aan te zetten in open forms? Ik heb gezien dat het kan in de formio documentatie. Het zou handig zijn als de redactie niet in de JSON hoeft te werken...

image

sergei-maertens commented 3 months ago

Can you please create an issue for this feature request in https://github.com/open-formulieren/open-forms/issues?

I understand the request and functionality, but we need to make sure all places affected by this are taken into account and we need a trace of which commits were made because of which issue/ticket and what the functional requirements are/were.

We deliberately do not expose the generic custom class name because it can cause support overhead with broken styling that is not because of our own code. For the content component, we expose pre-defined variants, I would also rather approach this the same way for consistency sake.

Robbert commented 2 months ago

I suppose we'll have to find another way.

sergei-maertens commented 2 months ago

Sorry - this just hasn't been prioritized yet by the stakeholder! We do want to work on this, there's just not been any communication about this issue afaik.