open-formulieren / open-forms-sdk

A Javascript SDK for Open Forms
https://open-forms.readthedocs.io/en/stable/developers/sdk/index.html
Other
2 stars 6 forks source link

✨ [open-formulieren/open-forms#4356] Expoints feedback integration #691

Closed stevenbal closed 1 month ago

stevenbal commented 2 months ago

https://github.com/open-formulieren/open-forms/issues/4356

Requires https://github.com/open-formulieren/open-forms/pull/4376 to be merged

TODO:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 12.00000% with 22 lines in your changes missing coverage. Please review.

Project coverage is 56.12%. Comparing base (4d03133) to head (33f5e7f).

Files Patch % Lines
src/components/analytics/ExpointsSnippet.js 5.55% 17 Missing :warning:
src/components/analytics/mocks.js 0.00% 5 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (4d03133) and HEAD (33f5e7f). Click for more details.

HEAD has 1 upload less than BASE | Flag | BASE (4d03133) | HEAD (33f5e7f) | |------|------|------| ||2|1|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #691 +/- ## =========================================== - Coverage 76.00% 56.12% -19.88% =========================================== Files 225 222 -3 Lines 4575 4030 -545 Branches 1235 724 -511 =========================================== - Hits 3477 2262 -1215 - Misses 1065 1564 +499 - Partials 33 204 +171 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stevenbal commented 1 month ago

@sergei-maertens and I discussed this this morning, this should be included by the backend, so I'll add the script there and close this PR