Closed vaszig closed 1 month ago
Attention: Patch coverage is 14.28571%
with 24 lines
in your changes missing coverage. Please review.
Project coverage is 63.01%. Comparing base (
3a3ec09
) to head (44bb611
).
Files | Patch % | Lines |
---|---|---|
src/components/modals/FormStepSaveModal.js | 14.28% | 23 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
While the fix is indeed adding validation, I'm missing some bits in this PR:
* Story updates/interaction tests -> `src/components/modals/FormStepSaveModal.stories.js` * Translations - now the validation errors are displayed always in English. See https://open-formulieren.github.io/open-forms-sdk/?path=/docs/developers-documentation--docs#handling-validation-errors-with-zod for instructions
Yes, sorry I forgot to do that as a draft. I wanted to add a story but again I would have forgotten the translations.
Fixes open-formulieren/open-forms#4382