search

open-formulieren / open-forms

Smart and dynamic forms
https://open-forms.readthedocs.io
Other
34 stars 25 forks source link

StUF-ZDS crashes if no URL is specified for the SOAP service #2510

Open pi-sigma opened 1 year ago

pi-sigma commented 1 year ago

Product versie / Product version

2.0.1

Omschrijf het probleem / Describe the bug

The StUF-ZDS registration plugin raises an error if the URL for the SOAP service is not specified, even though the URL field in the admin is not marked as required.

Stappen om te reproduceren / Steps to reproduce

  1. Create a SOAP service (My StUF-ZDS) and fill out Label and SOAP version, but leave the URL field empty
  2. Configure the StUF-ZDS plugin (under Miscellaneous -> StUF-ZDS configuratie) to use My StUF-ZDS
  3. Create a form with a text field that is linked to StUF-ZDS
  4. Fill in and submit the form
  5. Check the submission: a MissingSchema error is raised because of the missing URL

Verwacht gedrag / Expected behavior

Either the plugin should not crash when the URL is not specified, or the field should be marked as required

Screen resolution

None

Device

None

OS

None

Browser

No response

pi-sigma commented 1 year ago

My suspicion is that this never showed up because it doesn't make sense to create a SOAP service without specifying the URL of the service, which is why clients have always filled in the URL field. However, it would be good to have some idea why the URL field of the SoapService model (here) was marked as optional before proceeding.

joeribekker commented 1 year ago

Initial assessment: This might need some more admin validation/tweaking but seems like it only happens because of misconfiguration.

joeribekker commented 11 months ago

Refinement: @joeribekker sbould look into StUF documentation to see if the "main" SOAP URL could be used as one of the StUF URLs and whether StUF defines some logic for these different URLs.