TypeError: apply_map() missing 1 required positional argument: 'scoped_logic'

SilviaAmAm commented 1 year ago

Product versie / Product version

2.1.x

Omschrijf het probleem / Describe the bug

Sentry 328205

I saw this in the DH sentry, but it wasn't reported by them.

Using wrong JSON logic crashes form

Stappen om te reproduceren / Steps to reproduce

Create a form with:

A IBAN component with label iban
A radio component with variable options with the wrong json expression: {"map": [{"var": "iban"}]}

Fill in the form:

Enter an iban in the iban component
The form step crashes => The GET to the form step gives a 500

Verwacht gedrag / Expected behavior

I guess ideally the error should be caught when the form designer tries to save the form?

Screen resolution

None

Device

None

OS

None

Browser

No response

joeribekker commented 1 year ago

Refinement: Related to #2324

sergei-maertens commented 1 year ago

open-formulieren/InferNoLogic#1 will result in a client-side type checker that should prevent this. Leaving this ticket here as a specific check for integrating the type checker in the form designer.

joeribekker commented 7 months ago

Type inference feature was cancelled due to implementation difficulties vs benefits.

open-formulieren / open-forms