search

open-formulieren / open-forms

Smart and dynamic forms
https://open-forms.readthedocs.io
Other
33 stars 25 forks source link

Rectify API/service organization #3757

Open sergei-maertens opened 7 months ago

sergei-maertens commented 7 months ago

Version 2.4 did a big refactor on the API clients and moved a bunch of configuration into a more logical structure under the openforms.contrib package.

As part of 2.5, BRK integration is added in openforms.contrib.brk, which is introducing the pattern again that was being cleaned up in the refactor. BRK is both part of Haal Centraal, and a service provided by the Kadaster (https://www.kadaster.nl/zakelijk/registraties/basisregistraties/brk).

In my opinion, openforms.contrib.brk should be merged into openforms.contrib.kadaster to keep the code organization/structure consistent.

Additionally, there is more education required about these names so that we reduce confusion for developers implementing features.

joeribekker commented 7 months ago

Refinement: Let's first decide on the structure. If I follow the reasoning here, we should place BRP under Logius package?