search

open-formulieren / open-forms

Smart and dynamic forms
https://open-forms.readthedocs.io
Other
32 stars 24 forks source link

Log when URLs are filtered out by sanitation when sending mails. #4351

Open joeribekker opened 4 weeks ago

joeribekker commented 4 weeks ago

Thema / Theme

Admin

Omschrijving / Description

Currently, the removal of all links that are not allowed are silently performed without any logging. This should be logged somewhere.

Added value / Toegevoegde waarde

No response

Aanvullende opmerkingen / Additional context

No response

joeribekker commented 3 weeks ago

Refinement: Discussed whether to add this to the digest email AND log it... The digest email seems to include "things" that are somewhat dynamic (expiry date reached, external service down) while this is just wrong from the moment its configured, or its correct. It cannot suddenly become incorrect.

Let's add validation on ALL the email templates that check the allowed email domain list. For now, we can just add it based on the database (so not take into account that you update the mail template AND the allowed email template in the configuration at the same time).