search

open-formulieren / open-forms

Smart and dynamic forms
https://open-forms.readthedocs.io
Other
36 stars 26 forks source link

"required" asterisk for privacy and truth options are a line below the text #4614

Open LaurensBurger opened 2 months ago

LaurensBurger commented 2 months ago

Product versie / Product version

2.6.x - latest

Customer reference

No response

Omschrijf het probleem / Describe the bug

As mentioned in #3415

Known issue that was pushed back to fix, WYSIWYG markup in this layout turns out to be hard to fix. We'll need to consult with NL DS for this.

This is still an issue: image

Stappen om te reproduceren / Steps to reproduce

No response

Verwacht gedrag / Expected behavior

No response

Screen resolution

None

Device

None

OS

None

Browser

No response

sergei-maertens commented 2 months ago

Needs stakeholder to pick this up - I've had a post-it on my desk for months now with the solution (removing the WYSYWIG layer from the admin) and disallowing HTML tags. The latter bit may not be accepted by all stakeholders, so we need some discussion about the way forward.

joeribekker commented 2 months ago

Refinement: Can we see in the code/related issue who requested HTML-tags? In my opinion we should just remove the WYSIWYG editor. If I remember correctly, this was about a way to make the privacy-link-text editable. Maybe we can ONLY allow the "a"-element and not make it fully WYSIWYG .

This was estimated on: Assumption that its just a WYSIWYG editor for this label. Maybe something like this: {% link "privacy page" %} while the actual link is configured in the admin. Final direction to be decided, but 1 day?