Closed robinmolen closed 1 month ago
Attention: Patch coverage is 62.16216%
with 14 lines
in your changes missing coverage. Please review.
Project coverage is 96.56%. Comparing base (
ff04630
) to head (827f6ac
). Report is 35 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
src/openforms/formio/migration_converters.py | 17.64% | 13 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The chromatic tests are failing because either the DMN variable options aren't loaded yet, or for some reason the DMN select cannot be done correctly (This second fail is also inconsistent. Sometimes it succeeds, sometimes it fails...)
Maybe we should remove the dmn variable select check from the "Empty" DMN Action configuration test scenario
Closing in favour of #4730
Closes #4524
Changes
The variable dropdown now uses the react-select component. Allowing for searching within the options
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh
./bin/compilemessages_js.sh
Commit hygiene