open-formulieren / open-forms

Smart and dynamic forms
https://open-forms.readthedocs.io
Other
37 stars 26 forks source link

Use react-select in variable dropdown for better UX #4675

Closed robinmolen closed 1 month ago

robinmolen commented 2 months ago

Closes #4524

Changes

The variable dropdown now uses the react-select component. Allowing for searching within the options

Checklist

Check off the items that are completed or not relevant.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 62.16216% with 14 lines in your changes missing coverage. Please review.

Project coverage is 96.56%. Comparing base (ff04630) to head (827f6ac). Report is 35 commits behind head on master.

Files with missing lines Patch % Lines
src/openforms/formio/migration_converters.py 17.64% 13 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4675 +/- ## ========================================== - Coverage 96.61% 96.56% -0.05% ========================================== Files 746 746 Lines 25144 25174 +30 Branches 3302 3310 +8 ========================================== + Hits 24292 24309 +17 - Misses 589 601 +12 - Partials 263 264 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

robinmolen commented 2 months ago

The chromatic tests are failing because either the DMN variable options aren't loaded yet, or for some reason the DMN select cannot be done correctly (This second fail is also inconsistent. Sometimes it succeeds, sometimes it fails...)

Maybe we should remove the dmn variable select check from the "Empty" DMN Action configuration test scenario

sergei-maertens commented 1 month ago

Closing in favour of #4730