Closed sergei-maertens closed 1 month ago
Attention: Patch coverage is 80.00000%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 96.56%. Comparing base (
1ae8370
) to head (3e1e318
). Report is 4 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
src/openforms/forms/models/form_version.py | 50.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
oh I missed that one! I'll update
Closes #3705
Changes
I've grepped the project for
def __str__(self):
and checked all of them for their timestamp usages.__str__
fromSubmissionStep
, as it adds no value. As a counter point, the timestamps are now included in the admin inline.localtime
representationSubmissionStep
and removed the obsoleted_data
JSONField, which made it possible to use a tabular inline and that made it possible to display the timestamps in their own table columns without cluttering the submissions admin too much.Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh
./bin/compilemessages_js.sh
Commit hygiene