open-formulieren / open-forms

Smart and dynamic forms
https://open-forms.readthedocs.io
Other
37 stars 26 forks source link

[#4418] Add addressNl specific mappings to Objects API registration (variables tab) #4751

Closed vaszig closed 45 minutes ago

vaszig commented 1 month ago

Closes #4418

Changes

This PR handles the frontend part of the task

Checklist

Check off the items that are completed or not relevant.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 97.61905% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.60%. Comparing base (d985471) to head (8371e62). Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ons/contrib/objects_api/submission_registration.py 94.44% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4751 +/- ## ======================================= Coverage 96.60% 96.60% ======================================= Files 749 749 Lines 25540 25575 +35 Branches 3377 3384 +7 ======================================= + Hits 24674 24708 +34 Misses 604 604 - Partials 262 263 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

vaszig commented 4 days ago

FYI, we have to take into consideration the old forms that they already may have addressNL variable_mappings configured. We may need a data migration for this.

vaszig commented 53 minutes ago

Just a reminder for the translations and for https://github.com/open-formulieren/open-forms/pull/4751#issuecomment-2482412560

sergei-maertens commented 45 minutes ago

Just a reminder for the translations and for #4751 (comment)

I will do translations separately and I'll take a look at the data migration remark.